This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Fixed keyboard navigation in flipped orientations #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When orientation is HorizontalFlipped, reverse the meaning of a and d keys. When orientation is VerticalFlipped, reverse the meaning of w and s keys. I decided that making the change in the key handling code in insertText:(NSString*)theText was more intuitive than actually changing the meaning of left, right, up, and down in the move* methods. My original intent with the flipped layout code was to make the change as noninvasive as possible, this change is in keeping with that goal.
epreston
added a commit
that referenced
this pull request
Sep 5, 2012
Fixed keyboard navigation in flipped orientations. Thanks @cekoski
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When orientation is HorizontalFlipped, reverse the meaning of a and d
keys. When orientation is VerticalFlipped, reverse the meaning of w
and s keys.
I decided that making the change in the key handling code in
insertText:(NSString_)theText was more intuitive than actually changing
the meaning of left, right, up, and down in the move_ methods.
My original intent with the flipped layout code was to make the change
as noninvasive as possible, this change is in keeping with that goal.