Per wallet application #138
Open
+3,460
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of timestamp)
…ansfer pointers (used by global allocation)
Owner
Author
|
Fixed a bug in fee handling during transfer analysis. Also added check of actual amounts in tests. |
…ransaction_descriptors()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full implementation of per-wallet transfer analysis (discussed at #135) including comprehensive unit tests. This covers all the corner cases I was able to find. If you find a corner case that is not covered by a unit tests do let me know. Note that unit tests use Go style, table-driven format: this format is far superior to custom code and I think we should be using it for all new unit tests. Essentially it makes tests very easy to read and maintain: even non programmers could potentially read them and contribute ideas for new ones.
See an example of how to read and reason about RP2 Go-style unit tests here.
The code is essentially ready for review (except for a few minor lint issues).