Skip to content

Conversation

epourail
Copy link
Owner

@epourail epourail commented Jan 4, 2020

Q A
Bug Fix ? no
New Feature ? yes
Issue #1

Checklist:

  • Bug fix are covered by unit tests
  • New feature are covered by unit,api and acceptance tests
  • All tests passed
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change
  • Documentation is updated as necessary

Why this change is needed?

This feature adds the chart configuration to deploy on a Kubernetes environment

@epourail epourail force-pushed the feature/kubernetes branch from 56f17c7 to 5282d2f Compare January 7, 2020 09:19
@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #10   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity        1      1           
=======================================
  Files             1      1           
  Lines             5      5           
=======================================
  Hits              5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0614a...4584756. Read the comment docs.

@@ -0,0 +1,21 @@
1. Get the application URL by running these commands:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not required. You can delete it if you want.

description: A Helm base-chart for Kubernetes to deploy the api
name: template-api
version: 0.1.0
keywords:
Copy link
Collaborator

@Ealenn Ealenn Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keywords is used in repository UI / CLI search command. You can add

  • symfony
  • php
  • boilerplate
    ...

@@ -1,4 +1,4 @@
# Web service with PHP/Symfony
# API base-project with PHP/Symfony
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can generate automatically helm configuration Table with https://github.com/norwoodj/helm-docs or others tools

@@ -0,0 +1,15 @@
apiVersion: v1
appVersion: "1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Docker image tag of template here to avoid compatibility issues. If this chart can be used by any symfony application, you can copy the chart version. The chart is therefore insensitive as in your default values ‘values.yaml’ here nginx:stable

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be a semver

@Ealenn
Copy link
Collaborator

Ealenn commented Feb 8, 2020

To make it generic you can add an initialization container.
And add values to customize command and args 😇 Or enable ou disable this feature.
I think of doctrine here 💪

apiVersion: v1
appVersion: "1.0"
description: A Helm base-chart for Kubernetes to deploy the api
name: template-api
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is really important here, thinks generic and reusable. I suggest symfony. It will be available like this epourail/symfony

@epourail epourail added the invalid This doesn't seem right label Feb 11, 2020
@epourail
Copy link
Owner Author

It will be better to create a 'chart' repository and define the kubernetes chart configuration separated from the api.
This PR is deprecated.

epourail and others added 5 commits February 12, 2020 13:22
* Create the `run-tests.yml` github action to execute the unit and api tests, generate and publish the code coverage
* Create the `docker-build.yml` github action to build the docker images and execute the acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants