-
Notifications
You must be signed in to change notification settings - Fork 0
Add kubernetes chart configuration #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
56f17c7
to
5282d2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 100% 100%
Complexity 1 1
=======================================
Files 1 1
Lines 5 5
=======================================
Hits 5 5 Continue to review full report at Codecov.
|
@@ -0,0 +1,21 @@ | |||
1. Get the application URL by running these commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not required. You can delete it if you want.
description: A Helm base-chart for Kubernetes to deploy the api | ||
name: template-api | ||
version: 0.1.0 | ||
keywords: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keywords is used in repository UI / CLI search command. You can add
- symfony
- php
- boilerplate
...
@@ -1,4 +1,4 @@ | |||
# Web service with PHP/Symfony | |||
# API base-project with PHP/Symfony |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can generate automatically helm configuration Table with https://github.com/norwoodj/helm-docs or others tools
@@ -0,0 +1,15 @@ | |||
apiVersion: v1 | |||
appVersion: "1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Docker image tag of template here to avoid compatibility issues. If this chart can be used by any symfony application, you can copy the chart version. The chart is therefore insensitive as in your default values ‘values.yaml’ here nginx:stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be a semver
To make it generic you can add an initialization container. |
apiVersion: v1 | ||
appVersion: "1.0" | ||
description: A Helm base-chart for Kubernetes to deploy the api | ||
name: template-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is really important here, thinks generic and reusable. I suggest symfony
. It will be available like this epourail/symfony
It will be better to create a 'chart' repository and define the kubernetes chart configuration separated from the api. |
* Create the `run-tests.yml` github action to execute the unit and api tests, generate and publish the code coverage * Create the `docker-build.yml` github action to build the docker images and execute the acceptance tests
Checklist:
Why this change is needed?
This feature adds the chart configuration to deploy on a Kubernetes environment