Skip to content

Add NPM package.json with build scripts and update instructions. #25 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

Add NPM package.json with build scripts and update instructions. #25 #26

merged 1 commit into from
May 4, 2019

Conversation

epost
Copy link
Owner

@epost epost commented May 4, 2019

No description provided.

@epost epost merged commit 6f390b9 into master May 4, 2019
anttih
anttih reviewed May 5, 2019
View reviewed changes
package.json
"test": "test"
},
"scripts": {
"postinstall": "PATH=node_modules/.bin:$PATH bower install",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm automatically adds node_modules/.bin to the PATH.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks @anttih. Hmm, I think I must have something misconfigured because that didn't work for me. In particular, pulp couldn't find purs. Still, I've addressed your comment in #27, does that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttih anttih anttih left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epost @anttih