Skip to content

Issue #500: Reduce messages in bias_quantile() #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosbosse merged 2 commits into from
Nov 28, 2023
Merged

Issue #500: Reduce messages in bias_quantile() #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64435a3
Update bias_quantile to only produce a message once
nikosbosse Nov 24, 2023
5f182da
move error message from `bias_quantile_single_vector()` to `bias_quan…
nikosbosse Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions R/metrics-quantile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,14 @@ bias_quantile <- function(observed, predicted, quantile, na.rm = TRUE) {
if (is.null(dim(predicted))) {
dim(predicted) <- c(n, N)
}
if (!(0.5 %in% quantile)) {
message(
"Median not available, computing bias as mean of the two innermost ",
"quantiles in order to compute bias."
)
}
bias <- sapply(1:n, function(i) {
bias_quantile_single_vector(observed[i], predicted[i,], quantile, na.rm)
bias_quantile_single_vector(observed[i], predicted[i, ], quantile, na.rm)
})
return(bias)
}
Expand Down Expand Up @@ -437,10 +443,6 @@ bias_quantile_single_vector <- function(observed, predicted, quantile, na.rm) {
median_prediction <- predicted[quantile == 0.5]
} else {
# if median is not available, compute as mean of two innermost quantile
message(
"Median not available, computing as mean of two innermost quantile",
" in order to compute bias."
)
median_prediction <-
0.5 * predicted[quantile == max(quantile[quantile < 0.5])] +
0.5 * predicted[quantile == min(quantile[quantile > 0.5])]
Expand Down
7 changes: 7 additions & 0 deletions tests/testthat/test-metrics-quantile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,3 +791,10 @@ test_that("bias_quantile(): quantiles must be unique", {
quantiles <- c(0.3, 0.5, 0.8, 0.9)
expect_silent(bias_quantile(observed = 3, predicted, quantiles))
})

test_that("bias_quantile only produces one message", {
expect_message(
bias_quantile(observed, predicted[, -3], quantile[-3]),
"Median not available, computing bias as mean of the two innermost quantiles in order to compute bias."
)
})