-
Notifications
You must be signed in to change notification settings - Fork 25
Improve gh pages and rendering of Vignettes #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/dark mode toggle
render README action
Website fixes
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 22 22
Lines 1392 1392
=======================================
Hits 1265 1265
Misses 127 127
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Will circle back soon but just wanted to note if we are improving gh-pages we should move to an action that deploys an environment and tune when it triggers a bit more (so that it only runs on main and for PRs on main but doesn't deploy).
|
seabbs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says on the tin.
See comments above about alternatives with preferably and a better way to deploy the docs.
|
Deploying failed unfortunately.
I also created a new issue #317 as Sam suggested |

This PR
Thanks to @sbfnk who did most of the changes