Skip to content

Conversation

@nikosbosse
Copy link
Collaborator

@nikosbosse nikosbosse commented Jul 26, 2023

This PR

  • gets rid of the preferably package in _pkgdown.yml which had a light/dark theme toggle that didn't work properly
  • updates the gh pages deploy action to v4 and also cleans up files when triggered
  • introduces a gh action to automatically render the Readme from Readme.Rmd
  • removes links to vignettes that have been renamed
    Thanks to @sbfnk who did most of the changes

@nikosbosse nikosbosse changed the title Fix gh pages Improve gh pages and rendering of Vignettes Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #316 (f6254c5) into main (20f459c) will not change coverage.
The diff coverage is n/a.

❗ Current head f6254c5 differs from pull request most recent head 8605b17. Consider uploading reports for the commit 8605b17 to get more accurate results

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          22       22           
  Lines        1392     1392           
=======================================
  Hits         1265     1265           
  Misses        127      127           
Files Changed Coverage Δ
R/score.R 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nikosbosse nikosbosse requested a review from seabbs July 26, 2023 12:22
@seabbs
Copy link
Contributor

seabbs commented Jul 26, 2023

Will circle back soon but just wanted to note if we are improving gh-pages we should move to an action that deploys an environment and tune when it triggers a bit more (so that it only runs on main and for PRs on main but doesn't deploy).

  • rather than getting rid of preferably you could just turn off the switch because I think that is what is causing you issues.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin.

See comments above about alternatives with preferably and a better way to deploy the docs.

@nikosbosse nikosbosse merged commit b709010 into main Jul 28, 2023
@nikosbosse nikosbosse deleted the fix-gh-pages branch July 28, 2023 10:19
@nikosbosse
Copy link
Collaborator Author

Deploying failed unfortunately.

image

I also created a new issue #317 as Sam suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants