Make forecast unit clearer #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nikosbosse
commented
Jan 18, 2023
nikosbosse
commented
- add explanations in the documentation to make it clearer what the unit of a single forecast is and how it is inferred
Collaborator
Author
|
What we could potentially add to this PR or a new PR is an argument |
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 90.80% 90.80%
=======================================
Files 21 21
Lines 1284 1284
=======================================
Hits 1166 1166
Misses 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seabbs
approved these changes
Jan 18, 2023
Contributor
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
This is really nice. Need to add this to the news.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.