Merged
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Bugbot Autofix prepared fixes for 1 of the 1 bugs found in the latest run.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update performance module tests for React 19 compatibility by replacing
injectProfilingHookswith aonCommitFiberRootfallback.React 19 removed
internals.injectProfilingHooks, causing all performance module tests to fail with aTypeError. This PR introduces a compatibility layer that usesonCommitFiberRootand fiberPerformedWorkdata wheninjectProfilingHooksis unavailable, ensuring tests function correctly on modern React versions while maintaining support for older versions. The counting logic was also refined to prevent overcounting due to memo wrappers.Note
Medium Risk
Touches test/profiling infrastructure and relies on React fiber internals/flags, so it may be brittle across React versions and could change which components are counted as “rendered.”
Overview
Improves the render-counting helper used by rerender exercises to work across React versions by conditionally using
internals.injectProfilingHookswhen available and otherwise falling back toonCommitFiberRoottraversal.The fallback inspects committed fibers (filtering to user component tags and
PerformedWorkflag) and derives stable component display names to avoid miscounting with memo/forwardRef wrappers; the same logic is inlined into severalmemoized.test.tsfiles and implemented inshared/get-component-calls.tsx, with proper setup/teardown viatry/finally.Written by Cursor Bugbot for commit bcb2171. This will update automatically on new commits. Configure here.