Stop testing wording of errors #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wording of errors varies greatly between e.g. Chrome and Firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording of the errors varies greatly between e.g. Chrome and Firefox. Since tests were (presumably) written by someone using Chrome, users using Firefox wouldn't be able to get the tests to work. In this PR, tests are modified in such a way that they still fail on the initial playground version, and succeed when copying over the solution, for both browsers.
For completeness sake, here is how Firefox and Chrome word the error:
9.1 Chrome:
invalid time value, Firefox:invalid date9.2 Chrome:
Cannot read properties of null (reading 'toUpperCase'), Firefox:accountType is null9.3 same as 9.2
P.S. this is my very first contribution to an open source project ever 🚀