Skip to content

Validate password byte length #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kentcdodds merged 1 commit into from
Feb 7, 2025
Merged

Validate password byte length #919

kentcdodds merged 1 commit into from
Feb 7, 2025

Conversation

@markuslewin
Copy link
Contributor

@markuslewin markuslewin commented Feb 4, 2025

Checks the byte length of the string to determine whether password is too long to bcrypt.hash properly.

Test Plan

  1. Try to create a new user with password 😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀😀a (character length 37, byte length 73)
  2. Password is too long

@markuslewin markuslewin mentioned this pull request Feb 4, 2025
Closed
kentcdodds
kentcdodds approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great catch!

@kentcdodds kentcdodds merged commit 03b10d1 into epicweb-dev:main Feb 7, 2025
mohammedzamakhan referenced this pull request in mohammedzamakhan/epic-startup Aug 4, 2025
@markuslewin
Validate password byte length (#919)
986cc51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markuslewin @kentcdodds