fix: handling when session exists but user doesn't exist in db

[caprolactam]

change handling from authenticator.logout() to logout().

Why
This process is intended to remove invalid session about userId on both cookie and db sides, when userId which get from session doesn't exists in db.
We manage userId in authSessionStorage now. On the other hand, authenticator handle connection, which is stored in connectionSessionStorage. Therefore, even after authenticator.logout(), the information about the userId remains. This can cause infinite redirect. I think this is left over from the process when remix-auth and remix-auth-form were used for authentication.
Replace authenticator.logout() with logout(), but if necessary, I will add the process to destory connectionSession manually.
For example:

import { connectionSessionStorage } from '#app/utils/connections.server.ts'
// in action code.
const connectioSession = await connectionSessionStorage.getSession(
  request.headers.get('cookie'),
)
const responseInit = {
  headers: { 'set-cookie': connectionSessionStorage.destroySession(connectioSession) }
}
await logout({ request }, responseInit)

Test Plan

Checklist

• Tests updated
• Docs updated

[kentcdodds]

Wow! Thank you for finding this and fixing it!

I think your analysis is correct. This is left over code. I'm glad you've fixed it.