a better solution: wait at frame0 until getNumFramesRead() returns 0#62
Open
a better solution: wait at frame0 until getNumFramesRead() returns 0#62
Conversation
BenBradnick
reviewed
Sep 18, 2025
| } | ||
| } | ||
| while (acquire && (frameNumber < numFrames)) { | ||
| usleep(2); |
|
I'm happy for this to be merged as this won't affect the Xspress 3X systems. I presume the 2us sleep inside the while loop isn't needed to get this working and was left over from testing? As this is called for every frame rather than just the first. |
Contributor
Author
|
@BenBradnick, I have not had a chance to test master after merging #54. I'm not sure if these delays are needed only for the original Xspress3 series. I would suggest not merging yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this an even better solution to #60, as it explicitly waits for
getNumFramesRead()to return 0 before starting the check of whether this has advanced to the next frame.