Alarm handling with AMSG - #52
Open
pheest wants to merge 5 commits into
Open
Conversation
Collaborator
… request. Accepted changes to dbrec.c made byhttps://github.com/epics-modules/pull/48
Collaborator
Author
|
OK, done. I see test_db.py has continued conflicts that will need to be addressed. |
Collaborator
|
Thanks @pheest . I went ahead and merged the latest from master and resolved the conflicts. The main one being I renamed |
tynanford
requested changes
Aug 18, 2026
There does not appear to be a need for G._exec to be outside of the lock block.
tynanford
reviewed
Aug 19, 2026
| if alrm: | ||
| rec.setSevr(alrm) | ||
| if len(value)>len(self.vdata): | ||
| value = nval[:len(self.vdata)] |
Collaborator
There was a problem hiding this comment.
one more instance of nval here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates and expands on #48
In dbrec.c, I have added a third parameter 'amsg' to the call, defaulting to None.
Use of the 'z' argument means that either a string or None is accepted.
If it is None, NULL is the resulting C value.
If EPICS_VERSION is < 7.0.6, the parameter is ignored.
In ptable.py, the stat field is initialised to UDF_ALARM.
This will be overridden if the PINI field is "YES".
This ensures the value of the field matches the actual output value after initial processing.
The alarm, stat and amsg values are applied to both input and output records. This requires the record be scanned in order to update the status.
(My project need is to alert the user when an incorrect value is set that does not meet complex validation rules.)
In test_db.py, I have added tests to verify correct operation of both input and output record alarms.