Merged
Conversation
dirk-zimoch
force-pushed
the
win_C4390
branch
from
67a563b to
db2aa6c
Compare
mdavidsaver
reviewed
Nov 4, 2025
src/rpcClient/rpcClient.cpp
Outdated
| @@ -24,6 +24,9 @@ | |||
| # define TRACE(msg) std::cerr<<"TRACE: "<<CURRENT_FUNCTION<<" : "<< msg <<"\n" | |||
| #else | |||
| # define TRACE(msg) | |||
Member
There was a problem hiding this comment.
A less M$ solution would be:
# define TRACE(msg) while(0){}
Contributor
Author
There was a problem hiding this comment.
I was thinking of # define TRACE(msg) (void)0.
Contributor
Author
There was a problem hiding this comment.
I have implemented your suggestion.
';' : empty controlled statement found; is this the intent?
dirk-zimoch
force-pushed
the
win_C4390
branch
from
db2aa6c to
6cec5ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
';' : empty controlled statement found; is this the intent?
In this case, it is indeed the intent.