Repository navigation
feat(windows): add the sockets extension to the Windows SDK sets - #76
Open
luthermonson wants to merge 2 commits into
Open
luthermonson wants to merge 2 commits into
luthermonson wants to merge 2 commits into
Conversation
Linux and macOS already build sockets (added in #40). Add it to both Windows extension lists (MSVC and clang) and to the windows-shared preload set. PHP's ext/sockets/config.w32 needs only ws2_32.lib and Iphlpapi.lib, both already linked by ext/standard and by ephpm's Windows link line. Needed by phpIPAM, which refuses to run without it (ephpm/recipes issues/phpipam.md).
|
ePHPm Preview — deployed (health check pending)
Preview updates automatically on each push to this PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux and macOS already build `sockets` (it has been in `PHP_EXTENSIONS` since #40, and the published 8.5.11 Linux SDK ships `include/php/ext/sockets/`). Windows was the only gap. phpIPAM refuses to run without it (ephpm/recipes `issues/phpipam.md`); other apps calling `socket_*()` are affected the same way.
Changes:
Why it links: PHP's `ext/sockets/config.w32` (8.3 to 8.5) needs only `ws2_32.lib` and `Iphlpapi.lib`. `ext/standard` already adds `iphlpapi.lib`, and ephpm's Windows link line already has `ws2_32`. spc's `ext-sockets` has no OS restriction and no library dependency.
Not changed: `mirror-deps.yml` (sockets has no library dependency to mirror), the pinned SDK in ephpm's xtask.
Validation: a non-production Windows dispatch with a `release_tag_suffix` (see PR comments). No production build is dispatched by this PR; the SDK is rebuilt separately.