Skip to content

Comments

Toggle graphs in the training board olena#825

Merged
tharvik merged 6 commits intodevelopfrom
toggle-graphs-in-the-training-board-olena
Dec 6, 2024
Merged

Toggle graphs in the training board olena#825
tharvik merged 6 commits intodevelopfrom
toggle-graphs-in-the-training-board-olena

Conversation

@0L3N4
Copy link
Collaborator

@0L3N4 0L3N4 commented Nov 5, 2024

Client-side

Additions & Modifications:

  1. Enhanced DropdownCard Component:

    • The DropdownCard component was refactored to allow dynamic control over its state (collapsed or expanded) based on a passed parameter.
    • By default, the component remains open.
  2. Refinements in the Training Information Section:

    • Graphs within the Training Information section were encapsulated within the newly refactored DropdownCard component. This provides users the option to expand or collapse the graphical data, improving the clarity and organization of training details.
  3. Removed Training Logs from Training Information:

    • The Training Logs information was removed from the Training Information section, streamlining the display and focusing user attention on more important information.

@0L3N4 0L3N4 requested a review from tharvik November 5, 2024 13:06
@JulienVig JulienVig removed the request for review from tharvik November 5, 2024 13:43
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work! a few comments on how to improve it, please also fix the tests/lint found by the CI

@0L3N4 0L3N4 marked this pull request as ready for review November 12, 2024 10:47
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The TrainingInformation's test can still be improved a bit :)

Can you resolve tharvik's comments if addressed them?


expect(wrapper.findAll("#mapHeader li")).toHaveLength(3);
const listItems = wrapper.findAll("#mapHeader li");
expect(listItems.length === 0 || listItems.length === 3).toBe(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one length should be expected (is the advanced information open or closed by default?).

Can you break this down into two assertions: one when the length is expected to be 0 and another when the length should be 3? You can use cypress' .click() to toggle the advanced information.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is designed to validate the Training Logs section, which has been removed. Therefore, the test should only pass when the length is 0. However, does it make sense to keep this test at all, considering there is essentially nothing left for it to verify?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed you can remove it altogether!

@JulienVig JulienVig self-requested a review November 26, 2024 15:59
@JulienVig
Copy link
Collaborator

Hey @iamsherlocked1891, could you wait until Dec 5th to merge this PR? There a DISCO demo happening tomorrow so it would be safer to wait until it's past :)

@tharvik tharvik force-pushed the toggle-graphs-in-the-training-board-olena branch from 3ec8015 to b807d92 Compare December 6, 2024 15:40
@tharvik tharvik merged commit 1b361bb into develop Dec 6, 2024
@tharvik tharvik deleted the toggle-graphs-in-the-training-board-olena branch December 6, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants