Fix gpt-tfjs bugs, add tests and refactor code#658
Conversation
|
@tharvik do you have an opinion on putting the gpt-tfjs test spec file, which relies on tfjs-node, in the |
for now, there isn't a good place to put theses tests, it's de facto in |
The thing is that this test is independent of the task, I tried to keep it as unitary as possible. It only tests gpt-tfjs implementation and capabilities |
ho, I misread, I though it was requiring discojs-node, not tfjs-node; well done then! so yeah, having it in discojs-core makes clearly sense. you can add tfjs-node to dev deps, so that's available for building/testing but not exposed from discojs-core (sadly not enforced). |
tharvik
left a comment
There was a problem hiding this comment.
wouhou, we've a talking model, thanks!
mostly cosmetics changes, except for models/gpt changes
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Addresses items listed in #654 #656
Fixes #656:
Addresses parts of #654
Additionally