Conversation
94be14d to
b15a411
Compare
Merged
dbde2ea to
d3aa368
Compare
e96988c to
b9db50f
Compare
martinjaggi
approved these changes
Mar 22, 2024
JulienVig
approved these changes
Mar 25, 2024
Collaborator
JulienVig
left a comment
There was a problem hiding this comment.
Very good job thanks for your work!! No blocking comments
Collaborator
Collaborator
|
The PR is merging into 633-bump-node-tharvik rather than develop, is it intentional? |
Closes: #632
b9db50f to
d56b535
Compare
Collaborator
Author
it is! it was based on it and now that #633 is merged, the base branch is automatically changed to "develop". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move to the current ECMA standard of modules #632
in addition
wrtcsegfaulting dep bynode-datachannelmv fromwrtctonode-datachannel#633from a quick test, we can now support importing and using newer library, such as
gpt-tokenizeror Transformer.js