Solve UI bugs and add UI error feedback#624
Merged
Conversation
JulienVig
added
bug
tharvik
approved these changes
Feb 14, 2024
Collaborator
tharvik
left a comment
tharvik
left a comment
There was a problem hiding this comment.
well done, we need more errors (at least, make theses visible), thanks!
review: not blocking, just some potential improvements
discojs/discojs-core/src/dataset/data/preprocessing/tabular_preprocessing.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses web-client bugs and broken features. Fixes various typos.
Fixes 404 not found when clicking on Test after training #611
404 not found because some navigation were pointing at obsolete router endpoints.
Fixes Improve UI error handling #623
Add error handling with user feedback because the website used to crash silently.
Fixes UI Testing and Predicting with a model crashes silently #622
Testing and Predict used to crash because of multiple problems. First, 404 not found when clicking on Test after training #611 was throwing a 404 not found, then there were implementation mistakes in the actual testing and prediction, in part linked to preprocessing.