Add support for text data & tokenization#577
Merged
Conversation
martinjaggi
reviewed
Apr 20, 2023
| Tokenize = 'tokenize' | ||
| } | ||
|
|
||
| export function getPreprocessImage (task: Task): PreprocessText { |
Member
There was a problem hiding this comment.
should this one be called image?
Member
There was a problem hiding this comment.
also mind adding a comment if you will output a stream of token ids?
for LLMs, we can then also support datasets without any label being needed
also let's say where/how people could load different tokenizers (task config or hardcoded either is fine)
Contributor
Author
There was a problem hiding this comment.
I'll make sure that the PR follows your comments once it's out of the "draft" stage!
Member
|
very cool, thanks for getting this started! |
s314cy
force-pushed
the
572-tokenizer-support-s314cy
branch
2 times, most recently
from
283003b to
8834d99
Compare
s314cy
force-pushed
the
572-tokenizer-support-s314cy
branch
from
57803d6 to
e8c307f
Compare
s314cy
force-pushed
the
572-tokenizer-support-s314cy
branch
2 times, most recently
from
55be642 to
6711773
Compare
s314cy
force-pushed
the
572-tokenizer-support-s314cy
branch
2 times, most recently
from
699116f to
9c96d71
Compare
s314cy
force-pushed
the
572-tokenizer-support-s314cy
branch
from
bce22ad to
f78a7e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #572 and closes #491
add support for text data & tokenization:
this PR includes a rework of the data preprocessing pipeline, which is much more modular and makes it easy to add new preprocessing functions!
it also fixes the CI by: