Conversation
s314cy
added
bug
s314cy
suggested changes
Dec 29, 2022
Contributor
s314cy
left a comment
s314cy
left a comment
There was a problem hiding this comment.
thanks very much for the changes and bugfix :)
|
|
||
| const model = await this.getModel() | ||
|
|
||
| let features: Array<number | number[] | number[][] | number[][][] | number[][][][] | number[][][][][]> = [] |
Contributor
There was a problem hiding this comment.
the xs vector is always a batch of samples, hence we usually directly cast it as number[][] to avoid carrying TF.js's bad typing
| const ys = this.getLabel(e.ys as tf.Tensor) | ||
| const pred = this.getLabel(model.predict(xs, { batchSize: batchSize }) as tf.Tensor) | ||
|
|
||
| const currentFeatures = xs.arraySync() |
Contributor
There was a problem hiding this comment.
you might have to cast the result of arraySync to number[][] for the reason mentioned above :)
| const currentFeatures = xs.arraySync() | ||
|
|
||
| if (Array.isArray(currentFeatures)) { | ||
| features = [...features, ...currentFeatures] |
| throw new TypeError('features array is not correct') | ||
| } | ||
|
|
||
| groundTruth.push(...Array.from(ys)) |
Contributor
There was a problem hiding this comment.
maybe getLabel could call arraySync instead of dataSync (and cast) to avoid manually constructing an array
s314cy
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.