Conversation
martinjaggi
requested changes
Feb 20, 2023
Member
martinjaggi
left a comment
There was a problem hiding this comment.
added some comments. one goal to keep in mind is to make the Byzantine robust clipping such that it can later also be used in decentralized. so let's try to define the clipping center based on local info only (and try to minimize additional communication if any).
we should also write down some thoughts&docu on how it will work with async (whenever the buffer size is reached, we do an aggregation with that group, so that's a round)
0322805 to
7b5f30b
Compare
7b5f30b to
ecaa4fc
Compare
e545f84 to
d3992cb
Compare
6283798 to
d482335
Compare
93a6169 to
09a9863
Compare
s314cy
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discojs
Server
Changed the end-to-end test case for the federated setting to use both standard aggregator and byzantine-robust one. Also, the test is now considering the presence of multiple users, splitting the training data among them and validating the model computing the accuracy after the training phase. As last step, an assertion has been added to expect a reasonable accuracy after training.