Skip to content

Fix dynamic select get value an object #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix dynamic select get value an object #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a58a12a
fix if export maatwebsite in action
ahmadrio Apr 25, 2019
5457920
fix update actions fields
ahmadrio Apr 25, 2019
769261a
add attribute to set comunication on dynamic select
ahmadrio Aug 9, 2019
a98ae62
resolve fix to dynamic select value is typeof
ahmadrio Aug 10, 2019
834c136
return back an original params in method dependsNotEmpty
ahmadrio Aug 10, 2019
66b9f95
alternative typeof in validate value
ahmadrio Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/js/field.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions resources/js/components/FormField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,18 @@
}
},

created() {
Nova.$on('nova-dependency-container-' + this.field.attribute, this.dependencyChange)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this accomplish?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used for another components to call this component field

},

methods: {

registerDependencyWatchers(root) {
root.$children.forEach(component => {
if (this.componentIsDependency(component)) {

component.$watch('value', (value) => {
this.dependencyValues[component.field.attribute] = value;
this.dependencyValues[component.field.attribute] = (typeof value === 'object' ? value.value : value);
this.updateDependencyStatus()
}, {immediate: true})

Expand Down Expand Up @@ -73,7 +77,7 @@
return;
}

if(dependency.hasOwnProperty('value') && this.dependencyValues[dependency.field] !== dependency.value) {
if(dependency.hasOwnProperty('value') && this.dependencyValues[dependency.field] != dependency.value) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would say this change would be good, since first you as a dev should know what the value is that you are checking against, but also there are some odd type behaviors in JS that I don't think we want to mess with.
Is there a specific reason to convert this from !== to a !=?

this.dependenciesSatisfied = false;
return;
}
Expand Down
16 changes: 9 additions & 7 deletions src/HasDependencies.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,14 @@ protected function applyRulesForChildFields($childField)
*/
public function validateFields() {
$availableFields = [];
foreach ($this->action()->fields() as $field) {
if ($field instanceof NovaDependencyContainer) {
$availableFields[] = $field;
$this->extractChildFields($field->meta['fields']);
} else {
$availableFields[] = $field;
if (!is_null($this->action()->fields())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would the action fields ever be null? That's not the method signature of the method that returns fields and is more likely a problem with not following that method signature over a bug. That being said, do you have an example of this being an issue?

foreach ($this->action()->fields() as $field) {
if ($field instanceof NovaDependencyContainer) {
$availableFields[] = $field;
$this->extractChildFields($field->meta['fields']);
} else {
$availableFields[] = $field;
}
}
}

Expand All @@ -109,4 +111,4 @@ public function validateFields() {
return $field->getCreationRules($this);
})->all());
}
}
}