Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel of Edit Connection points dialog cause existed connection points eliminated #5209

Closed
AlexeyGirin opened this issue Aug 2, 2024 · 1 comment · Fixed by #5455 or #5482
Closed

Cancel of Edit Connection points dialog cause existed connection points eliminated #5209

AlexeyGirin opened this issue Aug 2, 2024 · 1 comment · Fixed by #5455 or #5482
Assignees
@rrodionov91
Labels
bug Flex mode Bucket: Flex canvas related mode Priority: High Snake mode Bucket: Snake mode related issues
Milestone
Ketcher 2.25.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 2, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macro mode
  2. Load from file using Add to Canvas way: Cancel of Edit Connection points dialog cause existed connection points eliminated.zip
    image
  3. Open Edit Connection points dialog
    image
  4. Change connections to R4-R4
    image
  5. Press Cancel button

Actual behavior
All connection points become available (i.e. unoccupied)
image

Expected behavior
No changes happen.
image

Versions

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.3.2-gb9ac1d93-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

Issues found while testing #4905
@AlexeyGirin AlexeyGirin added bug Priority: High Snake mode Bucket: Snake mode related issues Flex mode Bucket: Flex canvas related mode labels Aug 2, 2024
@rrodionov91 rrodionov91 self-assigned this Sep 9, 2024
@rrodionov91 rrodionov91 changed the title Preview: Cancel of Edit Connection points dialog cause existed connection points eliminated Cancel of Edit Connection points dialog cause existed connection points eliminated Sep 9, 2024
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5209 - Cancel of Edit Connection points dialog cause existed connect…
88cd64f 
…ion points eliminated
@rrodionov91 rrodionov91 linked a pull request Sep 9, 2024 that will close this issue
#5209 - Cancel of Edit Connection points dialog cause existed connection points eliminated #5455
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 9, 2024
@rrodionov91
#5209 - Cancel of Edit Connection points dialog cause existed connect…
35c110e 
…ion points eliminated (#5455)
rrodionov91 added a commit that referenced this issue Sep 10, 2024
@rrodionov91
#5209 - Cancel of Edit Connection points dialog cause existed connect…
0bb0b21 
…ion points eliminated
@rrodionov91 rrodionov91 linked a pull request Sep 10, 2024 that will close this issue
Backmerge: #5209 - Cancel of Edit Connection points dialog cause existed connection points eliminated #5482
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
Backmerge: #5209 - Cancel of Edit Connection points dialog cause exis…
9e201fc 
…ted connection points eliminated (#5482)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-09-14; 10:47:47
  • Indigo Toolkit Version 1.24.0-rc.2.0-g5f2751d70-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.138 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5209 - Cancel of Edit Connection points dialog cause exis…
5a6d0df 
…ted connection points eliminated (#5482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Flex mode Bucket: Flex canvas related mode Priority: High Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Ketcher 2.25.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin