Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some bonds remain selected on export to SVG in Snake mode #4658

Closed
AlexeyGirin opened this issue May 20, 2024 · 3 comments · Fixed by #5010
Closed

Some bonds remain selected on export to SVG in Snake mode #4658

AlexeyGirin opened this issue May 20, 2024 · 3 comments · Fixed by #5010
Assignees
@KristinaKasyanovskaya
Labels
bug Export to SVG/PNG Bucket: Bugs related to SVG/PNG export Flex mode Bucket: Flex canvas related mode Macromolecules Priority: Low
Milestone
Ketcher 2.25.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented May 20, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro
  2. Load from file: Some bonds remain selected.zip
  3. Switch to Flex mode
  4. Select all elements on the canvas (press CTRL+A)
  5. Export canvas to SVG

Actual behavior
Some bonds remain selected:
image

Expected behavior
All selection is removed
image

As per requirements:

Temporary objects(monomer preview near cursor, css cursor, selectors and e.t.c) should not be included into image.

Versions [e.g. v2.4.2].

  • Indigo Toolkit Version 1.21.0-dev.3.0-g6f55c664-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-20; 05:30:45
  • Chrome Version 124.0.6367.201 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4539
@AlexeyGirin AlexeyGirin added bug Macromolecules Flex mode Bucket: Flex canvas related mode Export to SVG/PNG Bucket: Bugs related to SVG/PNG export labels May 20, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone May 20, 2024
@KristinaKasyanovskaya KristinaKasyanovskaya self-assigned this Jul 5, 2024
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

Not fixed.
Bonds remain slightly selected
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
  • Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.73 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin reopened this Jul 25, 2024
Merged
11 tasks
@KristinaKasyanovskaya
Copy link
Collaborator

Not fixed.
Bonds remain slightly selected

Fix #5219

svvald pushed a commit that referenced this issue Aug 19, 2024
@KristinaKasyanovskaya
#4658-Some bonds remain selected on export to SVG in Snake mode (#5219)
4f4cdb7 
* feat: fix export to SVG in snake mode

* feat:change svg logic

* feat: remove unused class
@svvald svvald closed this as completed Aug 19, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 5, 2024

Tested. Bug fixed.

2024-09-05_11h26_12
2024-09-05_11h26_51

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@KristinaKasyanovskaya @Guch1g0v
#4658-Some bonds remain selected on export to SVG in Snake mode (#5219)
669e833 
* feat: fix export to SVG in snake mode

* feat:change svg logic

* feat: remove unused class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristinaKasyanovskaya KristinaKasyanovskaya

Labels
bug Export to SVG/PNG Bucket: Bugs related to SVG/PNG export Flex mode Bucket: Flex canvas related mode Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4659 - export result svg contains some labels that are selectable epam/ketcher
5 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff @KristinaKasyanovskaya