Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of ambiguous monomers in small molecules mode #4557

Closed
olganaz opened this issue Apr 30, 2024 · 2 comments · Fixed by #5399
Closed

Support of ambiguous monomers in small molecules mode #4557

olganaz opened this issue Apr 30, 2024 · 2 comments · Fixed by #5399
Assignees
@rrodionov91
Labels
feature request Macro-Micro Bucket: Macro-Micro View related issues Requirements Done Test Cases Written Test cases has been written for that issue variant_monomers
Milestone
Ketcher 2.25.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 30, 2024 •
edited by ljubica-milovic
Loading

Background
Support for ambiguous monomers in small molecules mode (black box).

Requirements

  1. Ambiguous monomers with a letter symbol (R, Y, M, K, S, W, H, B, V, D and N for RNA/DNA, and B, J, Z and X for peptides; see: #2015 and #5186 ) should be represented as those symbols in micromolecules mode.
  2. Other ambiguous monomers should be displayed as % in micromolecules mode.
  3. Previews for hovering over the monomers in miromolecules mode is identical to the previews in flex mode (related issue: #4555).

UX
image
@olganaz olganaz changed the title Macro: Support of variant monomers in small molecules mode Support of variant monomers in small molecules mode Apr 30, 2024
@rrodionov91 rrodionov91 added this to the Ketcher 2.25.0-rc.1 milestone Jul 22, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Aug 13, 2024
@AlexeyGirin
Copy link
Collaborator

Test cases added

@ljubica-milovic ljubica-milovic changed the title Support of variant monomers in small molecules mode Support of ambiguous monomers in small molecules mode Aug 26, 2024
@rrodionov91 rrodionov91 self-assigned this Aug 28, 2024
rrodionov91 added a commit that referenced this issue Aug 29, 2024
@rrodionov91
#4557 - Support of ambiguous monomers in small molecules mode
637b897 
- fixed ambiguous monomers in molecules mode
- fixed rna builder for ambiguous monomers
- fixed sequence mode for ambiguous monomers
rrodionov91 added a commit that referenced this issue Aug 29, 2024
@rrodionov91
#4557 - Support of ambiguous monomers in small molecules mode
a0d1ec5 
- fixed ambiguous monomers in molecules mode
- fixed rna builder for ambiguous monomers
- fixed sequence mode for ambiguous monomers
@rrodionov91 rrodionov91 linked a pull request Aug 29, 2024 that will close this issue
#4557 - Support of ambiguous monomers in small molecules mode #5399
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 30, 2024
@rrodionov91
#4557 - Support of ambiguous monomers in small molecules mode
bb23e67 
- fixed ambiguous monomers in molecules mode
- fixed rna builder for ambiguous monomers
- fixed sequence mode for ambiguous monomers
rrodionov91 added a commit that referenced this issue Aug 30, 2024
@rrodionov91
#4557 - Support of ambiguous monomers in small molecules mode (#5399)
6230560 
- fixed ambiguous monomers in molecules mode
- fixed rna builder for ambiguous monomers
- fixed sequence mode for ambiguous monomers
rrodionov91 added a commit that referenced this issue Sep 1, 2024
@rrodionov91
#4557 - Support of ambiguous monomers in small molecules mode (#5399)
8f94e77 
- fixed ambiguous monomers in molecules mode
- fixed rna builder for ambiguous monomers
- fixed sequence mode for ambiguous monomers
This was referenced Sep 5, 2024
Closed
Open
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 5, 2024 •
edited
Loading

Verified with issues
image
Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

@AlexeyGirin AlexeyGirin mentioned this issue Sep 10, 2024
Open
@AlexeyGirin AlexeyGirin mentioned this issue Sep 30, 2024
Closed
@AlinaLysenko AlinaLysenko mentioned this issue Sep 25, 2024
Closed
This was referenced Oct 16, 2024
Open
Open
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#4557 - Support of ambiguous monomers in small molecules mode (#5399)
3ccdc4c 
- fixed ambiguous monomers in molecules mode
- fixed rna builder for ambiguous monomers
- fixed sequence mode for ambiguous monomers
This was referenced Oct 17, 2024
Closed
Open
@AlexeyGirin AlexeyGirin mentioned this issue Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
feature request Macro-Micro Bucket: Macro-Micro View related issues Requirements Done Test Cases Written Test cases has been written for that issue variant_monomers
Projects
None yet
Milestone
Ketcher 2.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4557 - Support of ambiguous monomers in small molecules mode epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @olganaz @ljubica-milovic