Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Limit size of structures in preview #4212

Open
Zhirnoff opened this issue Mar 8, 2024 · 4 comments · Fixed by #5441 or #5510
Open

Macro: Limit size of structures in preview #4212

Zhirnoff opened this issue Mar 8, 2024 · 4 comments · Fixed by #5441 or #5510
Assignees
@rrodionov91
Labels
bug Common UI problems Bucket: Common UI problems Macromolecules Priority: High
Milestone
Ketcher 2.28.0-rc...

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Mar 8, 2024 •
edited by AlexeyGirin
Loading

Steps to Reproduce
Case 1

  1. Add some molecules and structures on canvas in micro mode ( e.g. Benzene ring, molecules )
  2. Switch to Macro mode and hover over abbreviations

Case 2

  1. Switch to Sequence mode
  2. Add Peptides
  3. Hover over Peptide letter

Actual behavior

  1. The benzene ring is scaled to preview window and displayed with thick bonds. Molecules are also displayed with a larger scale.
  2. Peptides are displayed with a larger scale.
    2024-03-07_22h19_37
    2024-03-08_10h58_47
    2024-03-08_10h58_56
    2024-03-29_17h46_32

Expected behavior
Limit sizes in preview
Scale is no larger than on the canvas with zoom 100%
image
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.19.0-rc.1]
@Zhirnoff Zhirnoff added this to the Ketcher 2.21.0-rc.1 milestone Mar 8, 2024
@Zhirnoff
Copy link
Collaborator Author

Test added to the automation table.

@AlexeyGirin
Copy link
Collaborator

Moved to Refined Backlog since no fix over 2 versions

@AlexeyGirin AlexeyGirin added the Common UI problems Bucket: Common UI problems label Apr 17, 2024
@AlexeyGirin
Copy link
Collaborator

After discussion with @vanoprenko we decided to got this issue fixed.
Added to scope of 2.23 and changed priority to High

DmitriiP-EPAM added a commit that referenced this issue Jul 4, 2024
@DmitriiP-EPAM
#4212 - Bugfix (Preview): Create and use MoleculeOrStructurePreview
7ed1760
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Jul 4, 2024 that will close this issue
#4212 – Macro: Limit size of structures in preview #4990
Closed
9 tasks
@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Jul 4, 2024
rrodionov91 added a commit that referenced this issue Sep 5, 2024
@rrodionov91
#4212 - Limit size of structures in preview
99c4757 
- fixed calculation of structure size for previews
rrodionov91 added a commit that referenced this issue Sep 5, 2024
@rrodionov91
#4212 - Limit size of structures in preview
a50473c 
- fixed calculation of structure size for previews
@rrodionov91 rrodionov91 linked a pull request Sep 5, 2024 that will close this issue
#4212 - Limit size of structures in preview #5441
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 11, 2024
@rrodionov91
#4212 - Limit size of structures in preview
f5a17e7 
- fixed calculation of structure size for previews
rrodionov91 added a commit that referenced this issue Sep 12, 2024
@rrodionov91
#4212 - Limit size of structures in preview
c2ab998 
- fixed calculation of structure size for previews
rrodionov91 added a commit that referenced this issue Sep 13, 2024
@rrodionov91
#4212 - Limit size of structures in preview (#5441)
c2e25c5 
- fixed calculation of structure size for previews
- updated screenshots
rrodionov91 added a commit that referenced this issue Sep 13, 2024
@rrodionov91
#4212 - Limit size of structures in preview (#5441)
7e6ea2d 
- fixed calculation of structure size for previews
- updated screenshots
@rrodionov91 rrodionov91 linked a pull request Sep 13, 2024 that will close this issue
Backmerge: #4212 - Limit size of structures in preview #5510
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Sep 13, 2024
@rrodionov91
#4212 - Limit size of structures in preview (#5441) (#5510)
4413b58 
- fixed calculation of structure size for previews
- updated screenshots
@Zhirnoff
Copy link
Collaborator Author

Tested. For standalone atoms on the canvas, it’s still not fixed. If an atom is connected by a bond to another atom, the preview looks okay, but in my opinion, it’s a bit too small. It’s also too small for Functional Groups. The ring structures are drawn with a thin bond on some sides, and some have changed their angle. After discussion with @AlexeyGirin and @rrodionov91 moved to 2.26
2024-09-16_14h13_39
2024-09-16_14h13_46
2024-09-16_14h18_13
2024-09-16_14h24_32
2024-09-16_14h26_04
2024-09-16_14h26_10
2024-09-16_14h26_17
2024-09-16_14h26_29

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.2]
Indigo version
[Version 1.24.0-rc.2]

@Zhirnoff Zhirnoff reopened this Sep 16, 2024
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#4212 - Limit size of structures in preview (#5441) (#5510)
e1292d9 
- fixed calculation of structure size for previews
- updated screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Common UI problems Bucket: Common UI problems Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.28.0-rc.1 (Current)
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @DmitriiP-EPAM