Skip to content

Back merge: Error opening MOL and RXN files with RBC/SUB/UNC queries #928 #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2023
Merged

Back merge: Error opening MOL and RXN files with RBC/SUB/UNC queries #928 #977

merged 3 commits into from
Jan 13, 2023

Conversation

even1024
Copy link
Collaborator

@even1024 even1024 commented Jan 9, 2023

Co-authored-by: Roman Porozhnetov roman_porozhnetov@epam.com

@even1024
rbc & subst -2 (#969)
1093165 
Co-authored-by: Roman Porozhnetov <roman_porozhnetov@epam.com>
AlexanderSavelyev
AlexanderSavelyev reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@AlexanderSavelyev AlexanderSavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests for substructure matcher for subst=-2

@even1024
Copy link
Collaborator Author

even1024 commented Jan 9, 2023

please add tests for substructure matcher for subst=-2

fixed

IvanMinin
IvanMinin reviewed Jan 10, 2023
View reviewed changes
@even1024 even1024 requested a review from IvanMinin January 10, 2023 09:36
@even1024 even1024 merged commit 59f3876 into master Jan 13, 2023
@even1024 even1024 deleted the bugfix/928-mol-rbc-asdrawn branch January 13, 2023 07:43
loimu pushed a commit that referenced this pull request Jan 17, 2023
@even1024
Back merge: Error opening MOL and RXN files with RBC/SUB/UNC queries #…
9621c5d 
…928 (#977)

* rbc & subst -2 (#969)

Co-authored-by: Roman Porozhnetov <roman_porozhnetov@epam.com>

* SUBST -2 test

* comment fixed

Co-authored-by: Roman Porozhnetov <roman_porozhnetov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev left review comments

@IvanMinin IvanMinin IvanMinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@even1024 @AlexanderSavelyev @IvanMinin