add copolymer support - indigo #2954
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Hi @martinuncountable , thanks for the PR, yes, it will be great to add some tests. Also, one regression test failed. Could you please fix it? |
|
one can find how to run python tests in readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic request
These bracket types are defined here: https://www.daylight.com/meetings/mug05/Kappler/ctfile.pdf (page 18 is an example)
Here is the ketcher change to support frontend editing of the brackets type: epam/ketcher#7162
TODO: I need to probably add tests for this.
#1234 – issue nameFor release/xx branch
Optional