Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2217 - The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2546

Merged
merged 1 commit into from
Oct 11, 2024
Merged

#2217 - The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2546

merged 1 commit into from
Oct 11, 2024
+402 −35

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Add UT

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach
#2217 The wrong direction of the arrows when exporting from CDXML (o…
01f1d75 
…r CDX, base64 cdx) format and two retrosynthetic arrows

Fix code. Add UT
@AliaksandrDziarkach AliaksandrDziarkach changed the title #2217 The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2217 - The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows Oct 10, 2024
This was linked to issues Oct 10, 2024
The wrong direction of the arrows when exporting from CDXML (or CDX, base64 cdx) format and two retrosynthetic arrows #2217
Closed
The diagonally retrosynthetic arrow becomes horizontal after export from the CDXML file (or CDX, base64 cdx) #2221
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit 3965eb7 into release/1.25 Oct 11, 2024
72 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2217-cdx-wrong-retrosynthetic-arrow branch October 11, 2024 10:37
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Oct 17, 2024 that may be closed by this pull request
The retrosynthetic arrow is not displayed when export file in CDXML, CDX, base64 CDX formats and arrow is vertical #2219
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AliaksandrDziarkach @AlexanderSavelyev