Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single up and single down bonds are displayed incorrect when save to PNG(svg) #2447

Closed
AnnaKosol opened this issue Sep 30, 2024 · 2 comments · Fixed by #2487 or #2489
Closed

Single up and single down bonds are displayed incorrect when save to PNG(svg) #2447

AnnaKosol opened this issue Sep 30, 2024 · 2 comments · Fixed by #2487 or #2489
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: Medium SVG/PNG Bucket: Bugs related to SVG/PNG export Team G
Milestone
Indigo-1.25.0-rc.2

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. add to the canvas
Снимок экрана 2024-09-30 в 15 15 31

ring with single up and single down bonds.ket.zip

  1. save to png (svg)

Expected behavior
Снимок экрана 2024-09-30 в 15 15 31

Actual behavior
Снимок экрана 2024-09-30 в 15 17 05

Environment details:

Issues found while testing #2175
@AnnaKosol AnnaKosol added Bug Priority: Medium SVG/PNG Bucket: Bugs related to SVG/PNG export labels Sep 30, 2024
@AliaksandrDziarkach
Copy link
Collaborator

Looks like this is ketcher issue - preview and saved file show different picture.

@AliaksandrDziarkach AliaksandrDziarkach added this to the Indigo-1.25.0-rc.2 milestone Oct 3, 2024
AliaksandrDziarkach added a commit that referenced this issue Oct 3, 2024
@AliaksandrDziarkach
#2447 - Preview: single up and single down bonds are displayed incor…
027f889 
…rect when save to PNG(svg)

Fix code.Add UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 3, 2024 that will close this issue
#2447 - single up and single down bonds are displayed incorrect when save to PNG(svg) #2487
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Oct 4, 2024
@AliaksandrDziarkach
Backmerge: #2447 - Preview: single up and single down bonds are displ…
ce93966 
…ayed incorrect when save to PNG(svg)

Backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 4, 2024 that will close this issue
Backmerge: #2447 - Preview: single up and single down bonds are displayed incorrect when save to PNG(svg) #2489
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Oct 4, 2024
@AliaksandrDziarkach
Backmerge: #2447 - Preview: single up and single down bonds are displ…
d4233f9 
…ayed incorrect when save to PNG(svg) (#2489)
AlexanderSavelyev pushed a commit that referenced this issue Oct 4, 2024
@AliaksandrDziarkach
#2447 - single up and single down bonds are displayed incorrect when…
ce97df6 
… save to PNG(svg) (#2487)
@AliaksandrDziarkach AliaksandrDziarkach changed the title Preview: single up and single down bonds are displayed incorrect when save to PNG(svg) Single up and single down bonds are displayed incorrect when save to PNG(svg) Oct 4, 2024
@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Oct 9, 2024
Closed
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: Medium SVG/PNG Bucket: Bugs related to SVG/PNG export Team G
Projects
None yet
Milestone
Indigo-1.25.0-rc.2
3 participants
@AliaksandrDziarkach @AlexeyGirin @AnnaKosol