Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sending integer enums #379

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Fix sending integer enums #379

merged 6 commits into from
Apr 12, 2022

Conversation

via-guy
Copy link
Contributor

@via-guy via-guy commented Apr 11, 2022

Enums were being converted to String, which would lead to the wrong type being sent in request bodies.

@Vovanella95
Copy link
Collaborator

Hi @via-guy , thanks for contribution. I will check changes in my swaggers and release new version if everything is OK.

@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #379 (cbcaead) into master (d3924c6) will decrease coverage by 0.49%.
The diff coverage is 67.85%.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   75.46%   74.97%   -0.50%     
==========================================
  Files           8        9       +1     
  Lines         860      879      +19     
==========================================
+ Hits          649      659      +10     
- Misses        211      220       +9
Impacted Files Coverage Δ
lib/src/models/swagger_enum.dart 46.15% <46.15%> (ø)
...b/src/code_generators/swagger_enums_generator.dart 57.36% <75.00%> (-0.39%) ⬇️
...ib/src/code_generators/swagger_generator_base.dart 97.50% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3924c6...cbcaead. Read the comment docs.

@Vovanella95 Vovanella95 merged commit c06fc7e into epam-cross-platform-lab:master Apr 12, 2022
@via-guy via-guy deleted the int-enums branch April 12, 2022 09:02
Vovanella95 pushed a commit that referenced this pull request Apr 14, 2022
Revert "Fix sending integer enums (#379)"
5313497 
This reverts commit c06fc7e.
Vovanella95 added a commit that referenced this pull request Apr 14, 2022
@Vovanella95
Reverted changes (#383)
c82f3ee 
* Revert "Add default values for enums (#381)"

This reverts commit c8899da.

* Revert "AllOf enum fix (#380)"

This reverts commit 80ebc18.

* Revert "Fix sending integer enums (#379)"

This reverts commit c06fc7e.

Co-authored-by: uladzimir_paliukhovich <>
via-guy added a commit to via-guy/swagger-dart-code-generator that referenced this pull request Apr 14, 2022
@via-guy
Fix sending integer enums (epam-cross-platform-lab#379)
0412121 
* Generate integer enum values
@via-guy via-guy mentioned this pull request Apr 14, 2022
Merged
Vovanella95 pushed a commit that referenced this pull request Apr 14, 2022
@via-guy
Undo reverts (#386)
6f96a6f 
* Fix sending integer enums (#379)

* Generate integer enum values

* AllOf enum fix (#380)

* Fix enum properties defined with allOf not having the enums. prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@via-guy @Vovanella95