Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunk strategy #2075

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix chunk strategy #2075

merged 2 commits into from
Oct 18, 2024

Conversation

lhwan
Copy link
Collaborator

@lhwan lhwan commented Oct 17, 2024

Description

Fix chunk strategy

How Has This Been Tested?

Knowledge base Upload multiple files without expanding the list when slicing
image

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit cf192a5 into main Oct 18, 2024
5 checks passed
@Aries-ckt Aries-ckt added the hacktoberfest-accepted hacktoberfest-accepted label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants