Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): sort line chart data according to time order #1639

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

chenluli
Copy link
Contributor

Description

The lines were connected according to the original order of the data. When the data was not arranged in chronological order, the lines were tangled in the line chart. This PR is to fix the issue by sorting the data by time when drawing the line chart

Snapshots:

before:
image

after:
Screenshot 2024-06-17 at 12 00 28

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added fix Bug fixes web Module: web labels Jun 17, 2024
Copy link
Collaborator

@Aralhi Aralhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for your immediate response. ❤️
image

@Aralhi Aralhi requested a review from 2976151305 June 17, 2024 04:38
@Aralhi Aralhi added enhancement New feature or request ChatDashboard Module: ChatDashboard labels Jun 17, 2024
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny marked this pull request as ready for review June 17, 2024 13:32
@csunny csunny merged commit 49b56b4 into eosphoros-ai:main Jun 17, 2024
3 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChatDashboard Module: ChatDashboard enhancement New feature or request fix Bug fixes web Module: web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants