-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ChatKnowledge): ChatKnowledge Support Keyword Retrieve #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aries-ckt
changed the title
feat: ChatKnowledge Support Keyword Retrieve
feat[ChatKnowledge]: ChatKnowledge Support Keyword Retrieve
Jun 11, 2024
Aries-ckt
changed the title
feat[ChatKnowledge]: ChatKnowledge Support Keyword Retrieve
feat(ChatKnowledge): ChatKnowledge Support Keyword Retrieve
Jun 11, 2024
csunny
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+
fangyinc
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hopshine
pushed a commit
to Hopshine/DB-GPT
that referenced
this pull request
Sep 10, 2024
…s-ai#1624) Co-authored-by: Fangyin Cheng <staneyffer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1623
Description
When to Use Keyword Retrieve:
Looking for something ultra-specific and already understand the topic
Research is narrowly focused with clear objectives
Queries contain unique proper nouns like brand names
Needs require fast results more than exhaustive relevancy For precise or time-sensitive queries, keyword search will target the exact terms efficiently. Vector search may meander with unnecessary semantic expansion.
How Has This Been Tested?
ChatKnowledge App
.env
Full Text
Test IndexStore in examples
Snapshots:
Include snapshots for easier review.
Checklist: