Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fix inconsistency between model recommendation charts and display charts #1615

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

chenluli
Copy link
Contributor

@chenluli chenluli commented Jun 7, 2024

add model response charts to chart advices
Screenshot 2024-06-07 at 15 20 22

@csunny csunny marked this pull request as ready for review June 7, 2024 08:33
Aralhi
Aralhi previously approved these changes Jun 7, 2024
Copy link
Collaborator

@Aralhi Aralhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@chenluli chenluli changed the title WIP: fix(web): fix inconsistency between model recommendation charts and display charts fix(web): fix inconsistency between model recommendation charts and display charts Jun 11, 2024
@github-actions github-actions bot added fix Bug fixes web Module: web labels Jun 11, 2024
csunny
csunny previously approved these changes Jun 13, 2024
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

2976151305
2976151305 previously approved these changes Jun 13, 2024
Copy link
Collaborator

@2976151305 2976151305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web/components/chart/autoChart/advisor/pipeline.ts Outdated Show resolved Hide resolved
web/components/chart/autoChart/charts/multi-line-chart.ts Outdated Show resolved Hide resolved
Aralhi
Aralhi previously approved these changes Jun 13, 2024
Copy link
Collaborator

@Aralhi Aralhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you contribution, LGTM.

2976151305
2976151305 previously approved these changes Jun 13, 2024
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit 28c67ef into eosphoros-ai:main Jun 13, 2024
4 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
…isplay charts (eosphoros-ai#1615)

Co-authored-by: hzh97 <2976151305@qq.com>
Co-authored-by: aries_ckt <916701291@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes web Module: web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants