Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve the issue of incorrect parameter echo for resources under app editing #1391

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

majianguang
Copy link
Contributor

…r app editing

Description

Resolve the issue of incorrect parameter echo for resources under app editing;
When editing the resource parameters of an app, randomly select a resource type and set the resource parameters, then click save; Click edit again to open, the resource parameters echoed are not saved resource parameters

How Has This Been Tested?

  1. open an app, then add one resource and set resource parameters.
  2. Open the app again and view the resource parameters that were set and saved in the previous step. Instead, select the first value from the drop-down list as a display.

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Apr 9, 2024
@csunny
Copy link
Collaborator

csunny commented Apr 9, 2024

To fix the checks error, you should use black . command to format code style

pip install black
black .

@majianguang

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc merged commit 048ec71 into eosphoros-ai:main Apr 9, 2024
0 of 2 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants