Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support oceanbase monaco plugin #1386

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

HSunboy
Copy link
Contributor

@HSunboy HSunboy commented Apr 7, 2024

Description

Integrate the OceanBase-monaco-plugin into monaco-editor

New Featues:

  1. Auto-completion for keywords, tables, functions, columns, etc., with support for MySQL and Oracle.
  2. Adaptive editor themes

How Has This Been Tested?

Snapshots:

image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@HSunboy HSunboy force-pushed the feat/ob-editor branch 2 times, most recently from 30b00e1 to e9324d9 Compare April 11, 2024 01:34
@csunny
Copy link
Collaborator

csunny commented Apr 11, 2024

very nice~
image

@yyhhyyyyyy
Copy link
Contributor

In my environment, I tested MySQL and the results were very good !
image
However, occasionally I couldn't achieve automatic word suggestions when testing with different keywords at the beginning.
image

@csunny
Copy link
Collaborator

csunny commented Apr 11, 2024

It's so good, but after packaging it through script/build_web_static.sh and starting it through the static file, the automatic association will not work.

Some errors as follows

image

@HSunboy
Copy link
Contributor Author

HSunboy commented Apr 11, 2024

In my environment, I tested MySQL and the results were very good ! image However, occasionally I couldn't achieve automatic word suggestions when testing with different keywords at the beginning. image

In the second case, the keyword should be followed by <;> to end the first statement. If the delimiter is not included, sql-parser will treat the two statements as one statement, which will result in the failure to trigger auto completion.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 53438a3 into eosphoros-ai:main Apr 13, 2024
4 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants