[TEST] Regression on CDU on setProps on shallow wrapped component

[ghost]

For #2020.

[ljharb]

Thanks! I've updated the tests and split out the "no state change" and "state change" cases, and added some more assertions.

[ljharb]

I suspect this is a bug in react's shallow renderer - I've filed facebook/react#15075 to investigate.

[ljharb]

I rebased this on top of #1981, which seems related, but one of the shallow tests still fails.

[ghost]

Added describeIfs to ensure the tests only run for 16.3and up

[ljharb]

Good catch :-) we still need to make the shallow test pass, though. Got any ideas for a fix?

[ghost]

The new commit satisfies the failing test, but are there any other conditions/test cases we should cover?

[ljharb]

Probably :-) but if all the tests are passing, and it looks reasonable, let's merge it!

[ghost]

Alrighty 👍

[dallonf]

What would it take for this fix to get released to NPM? I think I just got bitten by this bug when updating dependencies

[ljharb]

I'm waiting on a few more PRs to land before publishing the next semver-minor of enzyme itself.

[bdwain]

@ljharb are you still waiting for more versions? It would be nice to get bugfixes out ASAP since the latest release is presumably broken. I'd be happy to do a branch of 3.9.0 with just this if it would get released as 3.9.1

[ljharb]

I might be able to pull together a patch tomorrow; but there’s still a minor I’m hoping to land first.

[jdk243]

@ljharb any estimate of when this patch is going to make it to NPM? getting some test failures related to this issue after updating to 3.9.0

[joshmanders]

Is there any update on this? This is breaking our tests.

[cedosw]

Same here ... tests are failing because of this :(

[bdwain]

@ljharb seems like releases of things are going out, but not the main enzyme package itself. Any reason why there can't be a release? The latest version has been broken for 2 months while master has been fixed. Seems like it shouldn't be terrible to release a patch version of whatever is in master.

[sulemanof]

Really need this fix to be released 😢

[ljharb]

@bdwain every main enzyme release potentially creates a flurry of new issues, so it is in fact quite terrible to release it before it's ready. I'm still planning to get a few fixes in before releasing v3.10.

[ljharb]

v3.10.0 has now been released.