Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo from readme #1196

Closed
wants to merge 1 commit into from
Closed

Fix typo from readme #1196

wants to merge 1 commit into from

Conversation

lalnuo
Copy link

@lalnuo lalnuo commented Sep 29, 2017

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, but I'd prefer to lowercase every instance of enzyme.

@ljharb ljharb added the docs label Sep 29, 2017
@dubbha
Copy link
Contributor

dubbha commented Sep 29, 2017

This contradicts my previous PR, where I fix ES5 version:
#1194

Besides actually fixing the ES5 version, I also changes "Enzyme" to "enzyme" there. Because Adapter is a constructor here (used with "new"), but Enzyme is not.

Moreover, it is not needed at all in the ES6 example. In the basically the same example in https://github.com/airbnb/enzyme/blob/master/docs/installation/react-16.md it is omitted, and it makes perfect sense:

import { configure } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';

configure({ adapter: new Adapter() });

@ljharb
Copy link
Member

ljharb commented Sep 30, 2017

Closing since #1194 superseded it.

@ljharb ljharb closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants