Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add phantomjs Fixes #1144 #1147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graingert
Copy link
Contributor

No description provided.

@ljharb
Copy link
Member

ljharb commented Sep 26, 2017

Does this run the tests in phantom, or does it just enable them to be run in phantom?

Also it'd be ideal to run each browser as its own travis-ci build.

@graingert
Copy link
Contributor Author

graingert commented Sep 26, 2017

@ljharb I'm not sure how to configure it exactly (I can't see anywhere where Chrome is selected as the only browser)

Marking as WIP.

Also it'd be ideal to run each browser as its own travis-ci build.

yup and Browserstack.

@graingert graingert changed the title add phantomjs Fixes #1144 WIP: add phantomjs Fixes #1144 Sep 26, 2017
@graingert
Copy link
Contributor Author

@ljharb can you jump through all the hoops for getting Browserstack for OSS?

@graingert
Copy link
Contributor Author

@ljharb ah looks like karma tests are currently broken anyway. Will try again when they're working on master.

And yes currently the tests try to run Firefox, Chrome and Phantom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants