Enable no-unused-expressions ESLint rule #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -13,7 +13,7 @@ Returns a wrapper with the direct parent of the node in the current wrapper. | |||
|
|
|||
| ```jsx | |||
| const wrapper = mount(<ToDoList />); | |||
| expect(wrapper.find('ul').parent().is('div')).to.be.true;; | |||
| expect(wrapper.find('ul').parent().is('div')).to.equal(true);; | |||
|
LGTM, only the 2 nonblockers of the pre-existing double semicolons (those statements are REALLY terminated) |
iancmyers
force-pushed
the
enable-no-unused-expressions
branch
from
f5a0358 to
23d6bd2
Compare
|
@ljharb Went ahead and removed those extra semicolons. |
This enables the `no-unused-expressions` ESLint rule and fixes the corresponding violations. In fixing the errors I stumbled upon two tests that were broken. After discussing with @lelandrichardson, I've inverted the test case as the current behavior is the desired behavior.
iancmyers
force-pushed
the
enable-no-unused-expressions
branch
from
23d6bd2 to
cb9419f
Compare
ljharb
added a commit
that referenced
this pull request
Jan 7, 2016
[Refactor] Enable no-unused-expressions ESLint rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
no-unused-expressionsESLint rule and fixes the corresponding violations. In fixing the errors I stumbled upon two tests that were broken. After discussing with @lelandrichardson, I've inverted the test case as the current behavior is the desired behavior.Fixes #97