Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new react-is package for internal introspection #1538

Closed
aweary opened this issue Feb 24, 2018 · 3 comments
Closed

Use the new react-is package for internal introspection #1538

aweary opened this issue Feb 24, 2018 · 3 comments

Comments

@aweary
Copy link
Collaborator

aweary commented Feb 24, 2018

There is now an official package for introspection called react-is as of facebook/react#12199. We should use this in the React 16 adapter instead of manually copying over the element type constants.
@aweary aweary mentioned this issue Feb 24, 2018
Closed
@ljharb
Copy link
Member

ljharb commented Feb 24, 2018

Is it incompatible with older reacts? it'd be great to use it in all the adapters.

@aweary
Copy link
Collaborator Author

aweary commented Mar 29, 2018

I think it should be backwards compatible, I don't see why not!

@ljharb
Copy link
Member

ljharb commented Jun 26, 2018

@aweary looks like it might not be compatible with react 0.13 :-/ https://travis-ci.org/airbnb/enzyme/jobs/396931952

I'll use it on the other adapters for now tho.

@ljharb ljharb closed this as completed in 484d0f5 Jun 26, 2018
@ljharb ljharb mentioned this issue Jun 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @aweary