[WIP] aio.tasks: Improve error handling in iterator #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io>
|
✔️ Deploy Preview for nifty-bassi-e26446 ready! 🔨 Explore the source changes: 9710c9a 🔍 Inspect the deploy log: https://app.netlify.com/sites/nifty-bassi-e26446/deploys/61e7e200f3308e0008cb11a1 😎 Browse the preview: https://deploy-preview-183--nifty-bassi-e26446.netlify.app |
3 tasks
phlax
commented
Jan 19, 2022
| yield_exceptions=yield_exceptions) | ||
| async for thing in things: | ||
| yield thing[0] | ||
| if yield_exceptions and isinstance(thing, Exception): |
Member
Author
There was a problem hiding this comment.
if not yield_exceptions: raise thing
phlax
commented
Jan 19, 2022
| or (isinstance(result, ConcurrentError) | ||
| and not self.yield_exceptions)) | ||
| not self.yield_exceptions | ||
| and (isinstance(result, ConcurrentIteratorError) |
Member
Author
There was a problem hiding this comment.
ConcurrentIteratorError is a ConcurrentError - rationalize this
Member
Author
|
closing this for now, not sure if its wanted, and found better way to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
the
concurrentutil provides an async generator that yields results from awaitables as they are available.depending on the type of iterable passed to the util, it can also consume results from a (potentially async) generator in order to derive the iteration of awaitables.
currently, it accepts an argument
yield_exceptions- this has effect if any of the awaitables raise an error while being awaitedyield_exceptionscurrently has no effect if an error is raised while consuming the provided iterable, and instead aConcurrentIteratorErroris raisedthis PR will make
yield_exceptionshave the same effect upon an error raised while consuming its iterable, which means it can potentially continue iterating if the iterator is not blown