Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: deprecate envoy-java-control-plane-bot #109

Merged
merged 1 commit into from
Jun 17, 2019
Merged

build: deprecate envoy-java-control-plane-bot #109

merged 1 commit into from
Jun 17, 2019

Conversation

joeyb
Copy link
Contributor

@joeyb joeyb commented Jun 17, 2019

Similar to the protoc-gen-validate build, use the shared envoy-bot user rather than our envoy-java-control-plane-bot user.

Signed-off-by: Joey Bratton jbratton@salesforce.com

Similar to the protoc-gen-validate build, use the shared envoy-bot user rather than our envoy-java-control-plane-bot user.

Signed-off-by: Joey Bratton <jbratton@salesforce.com>
@codecov-io
Copy link

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage     92.88%   92.88%           
  Complexity      150      150           
=========================================
  Files            19       19           
  Lines           576      576           
  Branches         48       48           
=========================================
  Hits            535      535           
  Misses           32       32           
  Partials          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e19277...2faf28f. Read the comment docs.

@joeyb
Copy link
Contributor Author

joeyb commented Jun 17, 2019

@rmichela - When you get a chance, can you take a look at this and let me know if you think there is anything else I need to change to bring this build in line with how protoc-gen-validate does its deployments? I've already updated all of the GPG_*/SONATYPE_* env vars in CircleCI.

@rmichela
Copy link

I think it should "just work".

@joeyb joeyb merged commit f9e3f37 into master Jun 17, 2019
@joeyb joeyb deleted the envoy-bot branch June 17, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants