Build rate limit service config #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
force-pushed
the
rl-service-config
branch
from
3c55302
to
5bc330f
Compare
zirain
reviewed
Jan 16, 2023
|
@arkodg LGTM after you resolve #893 (comment). |
Merged
* Translates Xds IR into ratelimit service config https://github.com/envoyproxy/ratelimit#configuration Relates to envoyproxy#670 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
force-pushed
the
rl-service-config
branch
from
5bc330f
to
a63a1fa
Compare
Codecov Report
@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 63.51% 63.83% +0.31%
==========================================
Files 54 54
Lines 7617 7678 +61
==========================================
+ Hits 4838 4901 +63
+ Misses 2471 2468 -3
- Partials 308 309 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zirain
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #670
Signed-off-by: Arko Dasgupta arko@tetrate.io