Rate Limit Service config in EnvoyGateway API #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Defines the configuration needed to enable as well as connect the rate limit service to a redis database backend * This will be required to be set by the infrastructure admin if the app developers want the global rate limiting feature using `RateLimitFilter` Relates to envoyproxy#670 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
added
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 64.07% 63.36% -0.71%
==========================================
Files 51 53 +2
Lines 6869 7330 +461
==========================================
+ Hits 4401 4645 +244
- Misses 2194 2396 +202
- Partials 274 289 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kflynn
previously approved these changes
Jan 10, 2023
|
An appropriate RateLimitFilter status condition if EG is not configured per this PR. Note that I don't expect this point regarding status to be part of this PR but it should be tracked by a separate issue @arkodg. |
danehans
suggested changes
Jan 10, 2023
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
danehans
suggested changes
Jan 11, 2023
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
danehans
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RateLimitFilterRelates to #670
Signed-off-by: Arko Dasgupta arko@tetrate.io