Limit GHA to main and release branches #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
skriss
reviewed
Jun 1, 2022
lizan
reviewed
Jun 1, 2022
| @@ -1,10 +1,16 @@ | |||
| name: Build and Test | |||
| on: | |||
| push: | |||
| branches: | |||
| - "main" | |||
| - "release-v*" | |||
There was a problem hiding this comment.
we've already started with release-v0.1.0 (https://github.com/envoyproxy/gateway/tree/release-v0.1.0)
@danehans any idea why we picked this convention ?
There was a problem hiding this comment.
@arkodg I used Envoy as the model for Gateway release branch naming, substituting / with - since - is more widely used.
There was a problem hiding this comment.
cool thanks, I'll leave the PR as is, since the naming was intentional, we can change it, if we change the branch naming in the future
skriss
approved these changes
Jun 3, 2022
lianghao208
added a commit
to lianghao208/gateway
that referenced
this pull request
Jun 3, 2022
Limit GHA to main and release branches (envoyproxy#86)
|
xref #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arko Dasgupta arko@tetrate.io