Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details on Global Rate Limit implementation #858

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jan 4, 2023

Relates to #670

Signed-off-by: Arko Dasgupta arko@tetrate.io

Relates to envoyproxy#670

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner January 4, 2023 19:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #858 (b443a6f) into main (085e6fa) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   63.89%   64.11%   +0.21%     
==========================================
  Files          50       50              
  Lines        6523     6523              
==========================================
+ Hits         4168     4182      +14     
+ Misses       2093     2082      -11     
+ Partials      262      259       -3     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 48.94% <0.00%> (+1.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg added this to the 0.3.0-rc.1 milestone Jan 4, 2023
@arkodg arkodg added documentation Improvements or additions to documentation priority/high Label used to express the "high" priority level labels Jan 4, 2023
@arkodg arkodg requested a review from danehans January 5, 2023 20:58
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg merged commit 309566d into envoyproxy:main Jan 5, 2023
@arkodg arkodg deleted the rl-implementation-details branch January 5, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority/high Label used to express the "high" priority level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants