Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify ProviderResources close #835

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Dec 27, 2022

Signed-off-by: hejianpeng hejianpeng2@huawei.com

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain requested a review from a team as a code owner December 27, 2022 08:16
@codecov-commenter
Copy link

Codecov Report

Merging #835 (44450d2) into main (b741c72) will increase coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   64.97%   65.19%   +0.21%     
==========================================
  Files          50       50              
  Lines        6342     6344       +2     
==========================================
+ Hits         4121     4136      +15     
+ Misses       1969     1960       -9     
+ Partials      252      248       -4     
Impacted Files Coverage Δ
internal/cmd/server.go 8.10% <0.00%> (+0.28%) ⬆️
internal/message/types.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/controller.go 50.31% <0.00%> (+1.25%) ⬆️
internal/provider/kubernetes/helpers.go 79.50% <0.00%> (+5.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo merged commit ed72c15 into envoyproxy:main Dec 27, 2022
@zirain zirain deleted the simplify-runner-close branch December 28, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants